Update debugJsonValue to accept unknown (#535)

bufbuild · Aug 1, 2023 · 7add029 · 7add029
1 parent a6af1c1
commit 7add029
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/protobuf-bench/README.md b/packages/protobuf-bench/README.md
@@ -10,5 +10,5 @@ server would usually do.
 
 | code generator      | bundle size             | minified               | compressed         |
 |---------------------|------------------------:|-----------------------:|-------------------:|
-| protobuf-es         | 88,672 b      | 37,773 b | 9,865 b |
+| protobuf-es         | 88,669 b      | 37,770 b | 9,843 b |
 | protobuf-javascript | 394,384 b  | 288,761 b | 45,123 b |
diff --git a/packages/protobuf/src/private/json-format-common.ts b/packages/protobuf/src/private/json-format-common.ts
@@ -328,7 +328,7 @@ export function makeJsonFormatCommon(
   };
 }
 
-function debugJsonValue(json: JsonValue): string {
+function debugJsonValue(json: unknown): string {
   if (json === null) {
     return "null";
   }
@@ -338,7 +338,7 @@ function debugJsonValue(json: JsonValue): string {
     case "string":
       return json.length > 100 ? "string" : `"${json.split('"').join('\\"')}"`;
     default:
-      return json.toString();
+      return String(json);
   }
 }