Skip to content

Commit

Permalink
V2: Use suffix "Schema" for generated descriptors (#890)
Browse files Browse the repository at this point in the history
  • Loading branch information
@timostamm
timostamm authored Jun 14, 2024
1 parent 05acbc4 commit e8904fa
Show file tree
Hide file tree
Showing 283 changed files with 6,264 additions and 6,249 deletions.
10 changes: 5 additions & 5 deletions packages/bundle-size/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ usually do. We repeat this for an increasing number of files.
<!--- TABLE-START -->
| code generator | files | bundle size | minified | compressed |
|-----------------|----------|------------------------:|-----------------------:|-------------------:|
| protobuf-es | 1 | 123,186 b | 64,107 b | 14,974 b |
| protobuf-es | 4 | 125,381 b | 65,617 b | 15,624 b |
| protobuf-es | 8 | 128,159 b | 67,388 b | 16,147 b |
| protobuf-es | 16 | 138,667 b | 75,369 b | 18,490 b |
| protobuf-es | 32 | 166,562 b | 97,384 b | 23,962 b |
| protobuf-es | 1 | 123,138 b | 64,107 b | 14,966 b |
| protobuf-es | 4 | 125,327 b | 65,617 b | 15,608 b |
| protobuf-es | 8 | 128,089 b | 67,388 b | 16,135 b |
| protobuf-es | 16 | 138,539 b | 75,369 b | 18,451 b |
| protobuf-es | 32 | 166,330 b | 97,384 b | 23,898 b |
| protobuf-javascript | 1 | 339,613 b | 255,820 b | 42,481 b |
| protobuf-javascript | 4 | 366,281 b | 271,092 b | 43,912 b |
| protobuf-javascript | 8 | 388,324 b | 283,409 b | 45,038 b |
Expand Down
12 changes: 6 additions & 6 deletions packages/bundle-size/chart.svg
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/bundle-size/src/gen/protobuf-es/entry-1.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
// limitations under the License.

import { create, toBinary } from "@bufbuild/protobuf";
import { TimeOfDayDesc } from "./google/type/timeofday_pb";
import { TimeOfDaySchema } from "./google/type/timeofday_pb";

/* eslint-disable no-console */

// google/type/timeofday.proto
console.log(toBinary(TimeOfDayDesc, create(TimeOfDayDesc)).length);
console.log(toBinary(TimeOfDaySchema, create(TimeOfDaySchema)).length);
66 changes: 33 additions & 33 deletions packages/bundle-size/src/gen/protobuf-es/entry-16.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,55 +13,55 @@
// limitations under the License.

import { create, toBinary } from "@bufbuild/protobuf";
import { TimeOfDayDesc } from "./google/type/timeofday_pb";
import { QuaternionDesc } from "./google/type/quaternion_pb";
import { PostalAddressDesc } from "./google/type/postal_address_pb";
import { PhoneNumberDesc } from "./google/type/phone_number_pb";
import { MoneyDesc } from "./google/type/money_pb";
import { LocalizedTextDesc } from "./google/type/localized_text_pb";
import { IntervalDesc } from "./google/type/interval_pb";
import { FractionDesc } from "./google/type/fraction_pb";
import { ExprDesc } from "./google/type/expr_pb";
import { DecimalDesc } from "./google/type/decimal_pb";
import { DateTimeDesc, TimeZoneDesc } from "./google/type/datetime_pb";
import { DateDesc } from "./google/type/date_pb";
import { ColorDesc } from "./google/type/color_pb";
import { AttributeContextDesc } from "./google/rpc/context/attribute_context_pb";
import { ViewportDesc } from "./google/geo/type/viewport_pb";
import { LatLngDesc } from "./google/type/latlng_pb";
import { TimeOfDaySchema } from "./google/type/timeofday_pb";
import { QuaternionSchema } from "./google/type/quaternion_pb";
import { PostalAddressSchema } from "./google/type/postal_address_pb";
import { PhoneNumberSchema } from "./google/type/phone_number_pb";
import { MoneySchema } from "./google/type/money_pb";
import { LocalizedTextSchema } from "./google/type/localized_text_pb";
import { IntervalSchema } from "./google/type/interval_pb";
import { FractionSchema } from "./google/type/fraction_pb";
import { ExprSchema } from "./google/type/expr_pb";
import { DecimalSchema } from "./google/type/decimal_pb";
import { DateTimeSchema, TimeZoneSchema } from "./google/type/datetime_pb";
import { DateSchema } from "./google/type/date_pb";
import { ColorSchema } from "./google/type/color_pb";
import { AttributeContextSchema } from "./google/rpc/context/attribute_context_pb";
import { ViewportSchema } from "./google/geo/type/viewport_pb";
import { LatLngSchema } from "./google/type/latlng_pb";

/* eslint-disable no-console */

// google/type/timeofday.proto
console.log(toBinary(TimeOfDayDesc, create(TimeOfDayDesc)).length);
console.log(toBinary(TimeOfDaySchema, create(TimeOfDaySchema)).length);
// google/type/quaternion.proto
console.log(toBinary(QuaternionDesc, create(QuaternionDesc)).length);
console.log(toBinary(QuaternionSchema, create(QuaternionSchema)).length);
// google/type/postal_address.proto
console.log(toBinary(PostalAddressDesc, create(PostalAddressDesc)).length);
console.log(toBinary(PostalAddressSchema, create(PostalAddressSchema)).length);
// google/type/phone_number.proto
console.log(toBinary(PhoneNumberDesc, create(PhoneNumberDesc)).length);
console.log(toBinary(PhoneNumberSchema, create(PhoneNumberSchema)).length);
// google/type/money.proto
console.log(toBinary(MoneyDesc, create(MoneyDesc)).length);
console.log(toBinary(MoneySchema, create(MoneySchema)).length);
// google/type/localized_text.proto
console.log(toBinary(LocalizedTextDesc, create(LocalizedTextDesc)).length);
console.log(toBinary(LocalizedTextSchema, create(LocalizedTextSchema)).length);
// google/type/interval.proto
console.log(toBinary(IntervalDesc, create(IntervalDesc)).length);
console.log(toBinary(IntervalSchema, create(IntervalSchema)).length);
// google/type/fraction.proto
console.log(toBinary(FractionDesc, create(FractionDesc)).length);
console.log(toBinary(FractionSchema, create(FractionSchema)).length);
// google/type/expr.proto
console.log(toBinary(ExprDesc, create(ExprDesc)).length);
console.log(toBinary(ExprSchema, create(ExprSchema)).length);
// google/type/decimal.proto
console.log(toBinary(DecimalDesc, create(DecimalDesc)).length);
console.log(toBinary(DecimalSchema, create(DecimalSchema)).length);
// google/type/datetime.proto
console.log(toBinary(DateTimeDesc, create(DateTimeDesc)).length);
console.log(toBinary(TimeZoneDesc, create(TimeZoneDesc)).length);
console.log(toBinary(DateTimeSchema, create(DateTimeSchema)).length);
console.log(toBinary(TimeZoneSchema, create(TimeZoneSchema)).length);
// google/type/date.proto
console.log(toBinary(DateDesc, create(DateDesc)).length);
console.log(toBinary(DateSchema, create(DateSchema)).length);
// google/type/color.proto
console.log(toBinary(ColorDesc, create(ColorDesc)).length);
console.log(toBinary(ColorSchema, create(ColorSchema)).length);
// google/rpc/context/attribute_context.proto
console.log(toBinary(AttributeContextDesc, create(AttributeContextDesc)).length);
console.log(toBinary(AttributeContextSchema, create(AttributeContextSchema)).length);
// google/geo/type/viewport.proto
console.log(toBinary(ViewportDesc, create(ViewportDesc)).length);
console.log(toBinary(ViewportSchema, create(ViewportSchema)).length);
// google/type/latlng.proto
console.log(toBinary(LatLngDesc, create(LatLngDesc)).length);
console.log(toBinary(LatLngSchema, create(LatLngSchema)).length);
Loading

0 comments on commit e8904fa

Please sign in to comment.