Do not allow extensions as an argument to makeMapFieldInfo()

bufbuild · Jan 18, 2024 · eb9a200 · eb9a200
1 parent 4f9f909
commit eb9a200
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/protobuf/src/create-registry-from-desc.ts b/packages/protobuf/src/create-registry-from-desc.ts
@@ -280,6 +280,7 @@ function makeFieldInfo(
 ): PartialFieldInfo {
   switch (desc.fieldKind) {
     case "map":
+      assert(desc.kind == "field"); // maps are not allowed for extensions
       return makeMapFieldInfo(desc, resolver);
     case "message":
       return makeMessageFieldInfo(desc, resolver);
@@ -297,7 +298,7 @@ function makeFieldInfo(
 }
 
 function makeMapFieldInfo(
-  field: (DescField | DescExtension) & { fieldKind: "map" },
+  field: DescField & { fieldKind: "map" },
   resolver: Resolver,
 ): PartialFieldInfo {
   const base = {