Switch code size benchmark to use fflate #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
approved these changes
Mar 1, 2023
timostamm
added a commit
that referenced
this pull request
Mar 31, 2023
We have moved from brotli via zlib to gzip `fflate`, a pure JS implementation in #411. It allowed us to run diffchecks in CI on the results, but it forced us to use gzip instead of brotli. This PR switches back to brotli, but with a JS implementation instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the code size benchmark to use fflate instead of the Node.js
zlibmodule.We have seen slight variance of a couple of bytes between runs with the
zlibmodule, andfflatewill hopefully produce stable numbers. This allows us to enable diffchecks on the results, so that CI can ensure the report is always current.This switches the benchmark to use gzip compression instead of brotli, increasing the values for both libraries tested, but keeping the relative difference within a percentage point. Gzip is still widely used, so using it in the benchmark is not unrealistic.