Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equals for oneof #415

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Fix equals for oneof #415

merged 3 commits into from
Mar 6, 2023

Conversation

titanous
Copy link
Contributor

@titanous titanous commented Mar 6, 2023 •
edited
Loading

Fixes equals for oneof fields in messages.

  • Use value to read the actual field value
  • Add test cases for each type of field that can be in a oneof

@smaye81
Copy link
Member

smaye81 commented Mar 6, 2023

Hi, @titanous appreciate the fix. This is definitely worthwhile. Would you mind adding a proper description also?

@titanous
Copy link
Contributor Author

titanous commented Mar 6, 2023

Sure, I added a description.

timostamm
timostamm approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, appreciate the fix and the tests 🙏

I took the liberty to push up two commits to your branch to satisfy the linter.

@timostamm timostamm merged commit 4d6a630 into bufbuild:main Mar 6, 2023
@titanous titanous deleted the fix-equals-oneof branch March 6, 2023 21:18
This was referenced Mar 13, 2023
Closed
Closed
Merged
smaye81 added a commit that referenced this pull request Mar 14, 2023
@smaye81
Release 1.1.1 (#433)
5253331 
This release contains the following:

## Enhancements
*  Upgrade to protobuf v22.2 by @smaye81 in #429.

## Fixes
*  Fix equals for oneof by @titanous in #415.

## New Contributors
* @titanous made their first contribution in #415.

**Full Changelog**:
v1.1.0...v1.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@titanous @smaye81 @timostamm