Remove usage of globalThis in generated code #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
approved these changes
Jun 7, 2023
Merged
smaye81
added a commit
that referenced
this pull request
Jul 14, 2023
## What's Changed * Add `toPlainMessage` to convert `Message` objects to their `PlainMessage` variants by @srikrsna-buf in #511 * Remove usage of globalThis in generated code by @smaye81 in #504 * Use `typeof BigInt` to check for BigInt support by @lukasIO in #488 ## New Contributors * @lukasIO made their first contribution in #488. **Full Changelog**: https://github.com/bufbuild/protobuf-es/compare/v1.2.1..v1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the usage of
globalThisin generated code by instead using an export of globalNumberconstants.This is done so that we can safely use these global constants when generating code and be assured we're using the correct values. We cannot use
globalThissince we support ES2017 andglobalThiswas introduced in ES2020. We also don't want to explicitly generate code using, for example,Number.NaN, since this could clash with a message name ofNumber.Instead we can export them in a local
proto-double.jsfile since this will be in a different scope as the generated code and we are guaranteed to use the intended global values.Note that this complements #488 to remove usage of
globalThisin the repo.