Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow number[] for bytes fields in constructor #533

Merged
merged 7 commits into from
Jul 26, 2023

Conversation

srikrsna-buf
Copy link
Member

@srikrsna-buf srikrsna-buf commented Jul 25, 2023

Follow up work to #511. This doesn't change the types but loosens the runtime to also accept number[] alongside Uint8Array values for bytes fields.

@srikrsna-buf srikrsna-buf merged commit a6af1c1 into main Jul 26, 2023
@srikrsna-buf srikrsna-buf deleted the sk/loosen-constructor branch July 26, 2023 14:33
@srikrsna-buf srikrsna-buf mentioned this pull request Aug 30, 2023
srikrsna-buf added a commit that referenced this pull request Aug 30, 2023
## What's Changed
* #533 by @srikrsna-buf
* #535 by @GauBen 

## New Contributors
* @GauBen made their first contribution in #535.

**Full Changelog**:
https://github.com/bufbuild/protobuf-es/compare/v1.3.0..v1.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants