-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow number[]
for bytes
fields in constructor
#533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Jul 25, 2023
timostamm
reviewed
Jul 26, 2023
Co-authored-by: Timo Stamm <ts@timostamm.de>
timostamm
reviewed
Jul 26, 2023
timostamm
approved these changes
Jul 26, 2023
Merged
srikrsna-buf
added a commit
that referenced
this pull request
Aug 30, 2023
## What's Changed * #533 by @srikrsna-buf * #535 by @GauBen ## New Contributors * @GauBen made their first contribution in #535. **Full Changelog**: https://github.com/bufbuild/protobuf-es/compare/v1.3.0..v1.3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up work to #511. This doesn't change the types but loosens the runtime to also accept
number[]
alongsideUint8Array
values forbytes
fields.