Fix typing error in @bufbuild/protoplugin, improve error messages #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
approved these changes
Dec 5, 2023
Alfus
approved these changes
Dec 5, 2023
Merged
smaye81
added a commit
that referenced
this pull request
Dec 6, 2023
## What's Changed * Add explicit exports for Node by @smaye81 in #645 * Honor experimental editions in the preamble generated by `@bufbuild/protoplugin` by @timostamm in #644 * Fix typing error in `@bufbuild/protoplugin`, improve error messages by @timostamm in #642 * Support for proto2 groups by @timostamm in #640 **Full Changelog**: v1.5.0...v1.5.1
alecthomas
referenced
this pull request
in TBD54566975/ftl
Dec 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [@bufbuild/protoc-gen-es](https://github.com/bufbuild/protobuf-es) ([source](https://github.com/bufbuild/protobuf-es/tree/HEAD/packages/protoc-gen-es)) | [`1.5.0` -> `1.5.1`](https://renovatebot.com/diffs/npm/@bufbuild%2fprotoc-gen-es/1.5.0/1.5.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | [`18.2.42` -> `18.2.43`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.42/18.2.43) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [bit](https://github.com/alecthomas/bit) | `0.4.1` -> `0.4.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | patch | | [connectrpc.com/connect](https://github.com/connectrpc/connect-go) | `v1.12.0` -> `v1.13.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/jackc/pgx/v5](https://github.com/jackc/pgx) | `v5.5.0` -> `v5.5.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [pre-commit](https://github.com/pre-commit/pre-commit) | `3.5.0` -> `3.6.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | minor | | [prettier](https://prettier.io) ([source](https://github.com/prettier/prettier)) | [`3.1.0` -> `3.1.1`](https://renovatebot.com/diffs/npm/prettier/3.1.0/3.1.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [typescript](https://www.typescriptlang.org/) ([source](https://github.com/Microsoft/TypeScript)) | [`5.3.2` -> `5.3.3`](https://renovatebot.com/diffs/npm/typescript/5.3.2/5.3.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [watchexec](https://github.com/watchexec/watchexec) | `1.23.0` -> `1.24.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | minor | --- ### Release Notes <details> <summary>bufbuild/protobuf-es (@​bufbuild/protoc-gen-es)</summary> ### [`v1.5.1`](https://github.com/bufbuild/protobuf-es/releases/tag/v1.5.1) [Compare Source](https://github.com/bufbuild/protobuf-es/compare/v1.5.0...v1.5.1) #### What's Changed - Add explicit exports for Node by [@​smaye81](https://github.com/smaye81) in [https://github.com/bufbuild/protobuf-es/pull/645](https://github.com/bufbuild/protobuf-es/pull/645) - Honor experimental editions in the preamble generated by `@bufbuild/protoplugin` by [@​timostamm](https://github.com/timostamm) in [https://github.com/bufbuild/protobuf-es/pull/644](https://github.com/bufbuild/protobuf-es/pull/644) - Fix typing error in `@bufbuild/protoplugin`, improve error messages by [@​timostamm](https://github.com/timostamm) in [https://github.com/bufbuild/protobuf-es/pull/642](https://github.com/bufbuild/protobuf-es/pull/642) - Support for proto2 groups by [@​timostamm](https://github.com/timostamm) in [https://github.com/bufbuild/protobuf-es/pull/640](https://github.com/bufbuild/protobuf-es/pull/640) **Full Changelog**: bufbuild/protobuf-es@v1.5.0...v1.5.1 </details> <details> <summary>alecthomas/bit (bit)</summary> ### [`v0.4.2`](https://github.com/alecthomas/bit/releases/tag/v0.4.2) #### Changelog - [`308c8fc`](https://github.com/alecthomas/bit/commit/308c8fc) Configure renovate - [`1dcaf8f`](https://github.com/alecthomas/bit/commit/1dcaf8f) fix: combine outputs when using `bit -D deps` - [`77368bc`](https://github.com/alecthomas/bit/commit/77368bc) refactor: make Hasher public + move CSI under logging </details> <details> <summary>connectrpc/connect-go (connectrpc.com/connect)</summary> ### [`v1.13.0`](https://github.com/connectrpc/connect-go/releases/tag/v1.13.0) [Compare Source](https://github.com/connectrpc/connect-go/compare/v1.12.0...v1.13.0) #### What's Changed ##### Enhancements - Add `Schema` field to `connect.Spec` for introspection by [@​emcfarlane](https://github.com/emcfarlane) in [#​629](https://github.com/connectrpc/connect-go/issues/629) - Add support for dynamic message types via message initializers by [@​emcfarlane](https://github.com/emcfarlane) in [#​640](https://github.com/connectrpc/connect-go/issues/640) ##### Bugfixes - Type URLs in error details can have any host and even include URI scheme by [@​jhump](https://github.com/jhump) in [#​636](https://github.com/connectrpc/connect-go/issues/636) - Improve GET requests: clients should not include content headers, servers should disallow a body by [@​jhump](https://github.com/jhump) in [#​644](https://github.com/connectrpc/connect-go/issues/644) - Fix mis-categorization of "deadline exceeded" errors by [@​jhump](https://github.com/jhump) in [#​643](https://github.com/connectrpc/connect-go/issues/643) ##### Other changes - Improve test code and fix many sources of flakiness by [@​emcfarlane](https://github.com/emcfarlane) in [#​594](https://github.com/connectrpc/connect-go/issues/594), [#​624](https://github.com/connectrpc/connect-go/issues/624), [#​627](https://github.com/connectrpc/connect-go/issues/627), and [#​628](https://github.com/connectrpc/connect-go/issues/628) - Run conformance tests in CI by [@​jhump](https://github.com/jhump) in [#​642](https://github.com/connectrpc/connect-go/issues/642) - Internal refactoring to support future robustness improvements by [@​emcfarlane](https://github.com/emcfarlane) in [#​646](https://github.com/connectrpc/connect-go/issues/646) **Full Changelog**: connectrpc/connect-go@v1.12.0...v1.13.0 </details> <details> <summary>jackc/pgx (github.com/jackc/pgx/v5)</summary> ### [`v5.5.1`](https://github.com/jackc/pgx/compare/v5.5.0...v5.5.1) [Compare Source](https://github.com/jackc/pgx/compare/v5.5.0...v5.5.1) </details> <details> <summary>pre-commit/pre-commit (pre-commit)</summary> ### [`v3.6.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#360---2023-12-09) [Compare Source](https://github.com/pre-commit/pre-commit/compare/v3.5.0...v3.6.0) \================== ##### Features - Check `minimum_pre_commit_version` first when parsing configs. - [#​3092](https://github.com/pre-commit/pre-commit/issues/3092) PR by [@​asottile](https://github.com/asottile). ##### Fixes - Fix deprecation warnings for `importlib.resources`. - [#​3043](https://github.com/pre-commit/pre-commit/issues/3043) PR by [@​asottile](https://github.com/asottile). - Fix deprecation warnings for rmtree. - [#​3079](https://github.com/pre-commit/pre-commit/issues/3079) PR by [@​edgarrmondragon](https://github.com/edgarrmondragon). ##### Updating - Drop support for python<3.9. - [#​3042](https://github.com/pre-commit/pre-commit/issues/3042) PR by [@​asottile](https://github.com/asottile). - [#​3093](https://github.com/pre-commit/pre-commit/issues/3093) PR by [@​asottile](https://github.com/asottile). </details> <details> <summary>prettier/prettier (prettier)</summary> ### [`v3.1.1`](https://github.com/prettier/prettier/blob/HEAD/CHANGELOG.md#311) [Compare Source](https://github.com/prettier/prettier/compare/3.1.0...3.1.1) [diff](https://github.com/prettier/prettier/compare/3.1.0...3.1.1) ##### Fix config file search ([#​15363](https://github.com/prettier/prettier/pull/15363) by [@​fisker](https://github.com/fisker)) Previously, we start search for config files from the filePath as a directory, if it happened to be a directory and contains config file, it will be used by mistake. ```text ├─ .prettierrc └─ test.js (A directory) └─ .prettierrc ``` ```js // Prettier 3.1.0 await prettier.resolveConfigFile(new URL("./test.js", import.meta.url)); // <CWD>/test.js/.prettierrc // Prettier 3.1.1 await prettier.resolveConfigFile(new URL("./test.js", import.meta.url)); // <CWD>/.prettierrc ``` ##### Skip explicitly passed symbolic links with `--no-error-on-unmatched-pattern` ([#​15533](https://github.com/prettier/prettier/pull/15533) by [@​sanmai-NL](https://github.com/sanmai-NL)) Since Prettier v3, we stopped following symbolic links, however in some use cases, the symbolic link patterns can't be filtered out, and there is no way to prevent Prettier from throwing errors. In Prettier 3.1.1, you can use `--no-error-on-unmatched-pattern` to simply skip symbolic links. ##### Consistently use tabs in ternaries when `useTabs` is `true` ([#​15662](https://github.com/prettier/prettier/pull/15662) by [@​auvred](https://github.com/auvred)) <!-- prettier-ignore --> ```jsx // Input aaaaaaaaaaaaaaa ? bbbbbbbbbbbbbbbbbb : ccccccccccccccc ? ddddddddddddddd : eeeeeeeeeeeeeee ? fffffffffffffff : gggggggggggggggg; // Prettier 3.1.0 aaaaaaaaaaaaaaa ? bbbbbbbbbbbbbbbbbb : ccccccccccccccc ? ddddddddddddddd : eeeeeeeeeeeeeee ? fffffffffffffff : gggggggggggggggg; // Prettier 3.1.1 aaaaaaaaaaaaaaa ? bbbbbbbbbbbbbbbbbb : ccccccccccccccc ? ddddddddddddddd : eeeeeeeeeeeeeee ? fffffffffffffff : gggggggggggggggg; ``` ##### Improve config file search ([#​15663](https://github.com/prettier/prettier/pull/15663) by [@​fisker](https://github.com/fisker)) The Prettier config file search performance has been improved by more effective cache strategy. ##### Fix unstable and ugly formatting for comments in destructuring patterns ([#​15708](https://github.com/prettier/prettier/pull/15708) by [@​sosukesuzuki](https://github.com/sosukesuzuki)) <!-- prettier-ignore --> ```tsx // Input const { foo, // bar // baz }: Foo = expr; // Prettier 3.1.0 const { foo1, } // bar // baz : Foo = expr; // Prettier 3.1.0 second output const { foo1, // bar } // baz : Foo = expr; // Prettier 3.1.1 const { foo1, // bar // baz }: Foo = expr; ``` ##### Support "Import Attributes" ([#​15718](https://github.com/prettier/prettier/pull/15718) by [@​fisker](https://github.com/fisker)) [TypeScript 5.3](https://devblogs.microsoft.com/typescript/announcing-typescript-5-3/#import-attributes) supports the latest updates to the [import attributes](https://github.com/tc39/proposal-import-attributes) proposal. ```tsx import something from "./something.json" with { type: "json" }; ``` ##### Fix false claim in docs that cursorOffset is incompatible with rangeStart/rangeEnd ([#​15750](https://github.com/prettier/prettier/pull/15750) by [@​ExplodingCabbage](https://github.com/ExplodingCabbage)) The cursorOffset option has in fact been compatible with rangeStart/rangeEnd for over 5 years, thanks to work by [@​ds300](https://github.com/ds300). However, Prettier's documentation (including the CLI `--help` text) continued to claim otherwise, falsely. The documentation is now fixed. ##### Keep curly braces and `from` keyword in empty `import` statements ([#​15756](https://github.com/prettier/prettier/pull/15756) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```js // Input import { } from 'foo'; import { /* comment */ } from 'bar'; // Prettier 3.1.0 import {} from "foo"; import /* comment */ "bar"; // Prettier 3.1.1 import {} from "foo"; import {} from /* comment */ "bar"; ``` ##### Keep empty import attributes and assertions ([#​15757](https://github.com/prettier/prettier/pull/15757) by [@​fisker](https://github.com/fisker)) <!-- prettier-ignore --> ```js // Input import foo from "foo" with {}; import bar from "bar" assert {}; // Prettier 3.1.0 import foo from "foo"; import bar from "bar"; // Prettier 3.1.1 import foo from "foo" with {}; import bar from "bar" assert {}; ``` </details> <details> <summary>Microsoft/TypeScript (typescript)</summary> ### [`v5.3.3`](https://github.com/microsoft/TypeScript/releases/tag/v5.3.3): TypeScript 5.3.3 [Compare Source](https://github.com/Microsoft/TypeScript/compare/v5.3.2...v5.3.3) For release notes, check out the [release announcement](https://devblogs.microsoft.com/typescript/announcing-typescript-5-3/). For the complete list of fixed issues, check out the - [fixed issues query for Typescript 5.3.0 (Beta)](https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.3.0%22+is%3Aclosed+). - [fixed issues query for Typescript 5.3.1 (RC)](https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.3.1%22+is%3Aclosed+). - [fixed issues query for Typescript 5.3.2 (Stable)](https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.3.2%22+is%3Aclosed+). - [fixed issues query for Typescript 5.3.3 (Stable)](https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.3.3%22+is%3Aclosed+). Downloads are available on: - [NuGet package](https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild) </details> <details> <summary>watchexec/watchexec (watchexec)</summary> ### [`v1.24.0`](https://github.com/watchexec/watchexec/releases/tag/v1.24.0): CLI v1.24.0 *Software development often involves running the same commands over and over. Boring! Watchexec is a simple, standalone tool that watches a path and runs a command whenever it detects modifications. Install it today with [`cargo-binstall watchexec-cli`](https://github.com/cargo-bins/cargo-binstall), from the binaries below, find it [in your favourite package manager](https://github.com/watchexec/watchexec/blob/main/doc/packages.md), or build it from source with `cargo install watchexec-cli`.* ##### In this release: - New: start/stop messages are now in colour. Use `--colour=never` (`--color` also accepted) to disable, or the conventional `always` and `auto`. ([#​144](https://github.com/watchexec/watchexec/issues/144), [#​237](https://github.com/watchexec/watchexec/issues/237), [#​698](https://github.com/watchexec/watchexec/issues/698)) - New: `--timings` to print how long the command took. ([#​278](https://github.com/watchexec/watchexec/issues/278), [#​698](https://github.com/watchexec/watchexec/issues/698)) - New: `--quiet` to disable printing any message (except warning and error logs). ([#​698](https://github.com/watchexec/watchexec/issues/698)) - New: `--bell` to ring the terminal bell on command end. ([#​238](https://github.com/watchexec/watchexec/issues/238), [#​698](https://github.com/watchexec/watchexec/issues/698)) - New: `--ignore-nothing` to switch on all the `--no-*-ignore` flags. ([#​275](https://github.com/watchexec/watchexec/issues/275), [#​625](https://github.com/watchexec/watchexec/issues/625), [#​695](https://github.com/watchexec/watchexec/issues/695)) - New: `--only-emit-events` disables launching a command, and only prints events to stdout. Requires `--emit-events-to` to specify the format to print. This lets you obtain a stream of change events to handle directly rather than mediating via a command. ([#​676](https://github.com/watchexec/watchexec/issues/676), [#​691](https://github.com/watchexec/watchexec/issues/691)) - New: `--map-signal` to map signals received by Watchexec to other signals sent to the command. ([#​151](https://github.com/watchexec/watchexec/issues/151), [#​387](https://github.com/watchexec/watchexec/issues/387), [#​710](https://github.com/watchexec/watchexec/issues/710)) - Change: `--emit-events-to` `stdin` and `json-stdin` modes are renamed to `stdio` and `json-stdio` respectively; the old names are aliased to preserve compatibility. ##### Other changes: - Uses the [Watchexec library 3.0](https://github.com/watchexec/watchexec/blob/main/crates/lib/CHANGELOG.md#v300-2023-11-26). ([#​601](https://github.com/watchexec/watchexec/issues/601)) - `-w /dev/null` disables watching any files. This is the literal string `/dev/null`, it won't detect the null device via links or fifos. ([#​601](https://github.com/watchexec/watchexec/issues/601)) - Running as PID1 (e.g. in Docker) is fully supported. ([#​140](https://github.com/watchexec/watchexec/issues/140), [#​601](https://github.com/watchexec/watchexec/issues/601), [#​624](https://github.com/watchexec/watchexec/issues/624)) - Performance improvements and bugfixes around reaping processes (via `command-group` 5). ([#​601](https://github.com/watchexec/watchexec/issues/601)) - Performance improvements and bugfixes around watching files (via `notify` 6). ([#​601](https://github.com/watchexec/watchexec/issues/601)) - Clear the screen *before* printing events, so `--print-events` and `--clear` can meaningfully be used together. ([#​601](https://github.com/watchexec/watchexec/issues/601)) - Hint that more or less help is available with long `--help` and short `-h` flags. ([#​601](https://github.com/watchexec/watchexec/issues/601)) - The PDF version of the manual page is gone, due to the tooling I used disappearing, and the general ugliness of its typesetting. ([#​710](https://github.com/watchexec/watchexec/issues/710)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/TBD54566975/ftl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createEcmaScriptPluginfrom@bufbuild/protoplugincan parse custom plugin options with a user-provided function:The typing is incorrect. If an option without a value is provided (for example
opt: foo),valueis an empty string, not undefined, as one might think. Value is actually neverundefined. This PR adjusts the typing to match the actual behavior.Additionally, this PR improves error messages when parsing invalid plugin options. For example, when
opt: xis set forprotoc-gen-es:$ buf generate protoc-gen-es: invalid option "x=This PR changes the error message to read
invalid option "x".