Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example and tests to use the .binpb extension for binary Protobuf data #676

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Update example and tests to use the .binpb extension for binary Protobuf data #676

merged 1 commit into from
Jan 23, 2024

Conversation

timostamm
Copy link
Member

In our example, we write binary Protobuf data to disk with the file extension .bin.

This PR updates the example to use the file extension .binpb instead, which is the new recommendation added to the documentation last summer.

@timostamm timostamm merged commit 51573c3 into main Jan 23, 2024
5 checks passed
@timostamm timostamm deleted the tstamm/use-binpb-suffix branch January 23, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikrsna-buf srikrsna-buf srikrsna-buf approved these changes

@smaye81 smaye81 Awaiting requested review from smaye81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timostamm @srikrsna-buf