V2: Strip only last .proto suffix for DescFile.name #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
commented
Apr 23, 2024
| @@ -443,15 +443,15 @@ function addFile(proto: FileDescriptorProto, reg: MutableRegistry): void { | |||
| proto, | |||
| deprecated: proto.options?.deprecated ?? false, | |||
| edition: getFileEdition(proto), | |||
| name: proto.name.replace(/\.proto/, ""), | |||
| name: proto.name.replace(/\.proto$/, ""), | |||
There was a problem hiding this comment.
Previously, this removed the first sub-string.
| `syntax="proto3";`, | ||
| "foo.proto/baz.proto.proto", | ||
| ); | ||
| expect(file.name).toBe("foo.proto/baz.proto"); |
There was a problem hiding this comment.
Without the change above, name would be "foo/baz.proto.proto".
| @@ -829,7 +829,7 @@ function newField( | |||
| keyField.scalar != ScalarType.FLOAT && | |||
| keyField.scalar != ScalarType.DOUBLE, | |||
| ); | |||
| const valueField = mapEntry.fields.find((f) => f.proto.number === 2); | |||
| const valueField = mapEntry.fields.find((f) => f.number === 2); | |||
There was a problem hiding this comment.
We can use DescField.number here, no need to go through FieldDescriptorProto.
srikrsna-buf
approved these changes
Apr 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.