V2: For deprecated elements, generate a @deprecated tag on descriptors #818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #814 (comment), this adds a
@deprecated
tag to generated descriptors. For example:Already generates:
With this change, the descriptor is also marked deprecated:
Previously, we generated line comments for descriptors, but since the
@deprecated
tag is ignored in line comments, we're switching to block comments.This also improves implicit deprecation: If a message, extension, or enum is nested in a deprecated message, it is also generated with a
@deprecated
tag. Similar for files that are marked deprecated.