V2: Speed up reflect with classes #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
commented
May 10, 2024
| // prettier-ignore | ||
| type ReflectGetValue<Field extends DescField = DescField> = ( | ||
| export type ReflectGetValue<Field extends DescField = DescField> = ( |
There was a problem hiding this comment.
We can't infer all types with a class implementation, so we have to export this type. Another disadvantage is that classes are more verbose, hence the small bump in bundle size.
| @@ -224,64 +278,88 @@ function assertOwn(owner: Message, member: DescField | DescOneof) { | |||
| export function reflectList<V>( | |||
| field: DescField & { fieldKind: "list" }, | |||
| unsafeInput?: unknown[], | |||
| check = true, | |||
There was a problem hiding this comment.
This is new, and not final yet, see existing comment on line 51. We're not using it yet.
srikrsna
approved these changes
May 10, 2024
srikrsna-buf
approved these changes
May 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #836, we can make another performance improvement by using classes for
ReflectMessage,ReflectListandReflectMap: