Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Improve parameter parsing #880

Merged
merged 4 commits into from
Jun 6, 2024
Merged

V2: Improve parameter parsing #880

merged 4 commits into from
Jun 6, 2024

Conversation

srikrsna-buf
Copy link
Member

Improve parameter parsing by passing the parsed options to the generate functions. This also provides the EcmaScript options in generate.

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just left some comments regarding documenting the feature.

packages/protoplugin/src/parameter.ts Outdated Show resolved Hide resolved
packages/protoplugin/src/schema.ts Outdated Show resolved Hide resolved
packages/protoplugin/src/create-es-plugin.ts Outdated Show resolved Hide resolved
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srikrsna-buf srikrsna-buf merged commit 185b730 into v2 Jun 6, 2024
6 checks passed
@srikrsna-buf srikrsna-buf deleted the sk/parse-options branch June 6, 2024 13:53
@timostamm timostamm mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants