Backport binary encoding from "wire" subpath #885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
commented
Jun 12, 2024
| @@ -1,8 +1,5 @@ | |||
| { | |||
| "files": [ | |||
| "src/index.ts", | |||
| "src/private/options-map.ts" // not yet exported, added here to satisfy the linter | |||
There was a problem hiding this comment.
Removed options-map.ts - v2 provides options via descriptors.
|
This isn't working out well. We can't make use of the code in v1, so it's dead weight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upcoming version 2, we relaxed validation in BinaryWriter (see #877), and provided a better way for users to bring their own UTF-8 encoder (see 7080556).
For better interoperability between v1 and v2, this PR backports the relevant parts of the "wire" subpath.