V2: Use JsonObject to represent google.protobuf.Struct #893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The well-known message google.protobuf.Struct stores a dynamic object with the same range of types as a plain object in JSON. Unfortunately, it is cumbersome to construct a
Struct
message, and we recommend to usefromJson()
to do so.This PR changes the generated code to represent
google.protobuf.Struct
withJsonObject
. For example:Generated code before:
Generated code with this PR:
JsonObject
is defined as:The change applies to all fields, singular and repeated, map values, oneof members, and extensions. The generated messages
Struct
,Value
, andListValue
from@bufbuild/protobuf/wkt
are exempt, and remain unchanged.Bundle size increases by 2%, performance does not regress.