Protoc allows "-nan" and is lenient for "inf" and "nan" inside message literals #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
cc @jacobbuf |
Alfus
reviewed
Dec 8, 2023
Alfus
approved these changes
Dec 8, 2023
jhump
added a commit
that referenced
this pull request
Jan 11, 2024
jhump
added a commit
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires adding
nanto the list of keywords, so we can model the special float value-nanin the grammar.I also made some minor simplifications in here by combining
UintLiteralandIntLiteralinto a singleIntLiteralproduction (which can be optionally signed).This also contains a correction to the set of identifiers that can be used for boolean values in the text format. The previous text indicated that
TandFcould be used, but that's incorrect: it's lower-casetandfthat can be used.TODO: updating the example grammars to reflect these latest fixes