-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix in
rule for repeated int32
#1240
Conversation
Hi @mortezaPRK thanks for the patch! Looks like the lookup was also not generated in the C++ codegen either. |
@mortezaPRK maybe the best path forward is to split this into 2 different PRs. Keep the fixes for Go in this PR and remove the tests you added so we can get this merged as an incremental improvement. Then open a separate PR to add the tests (which will still fail, but will be a reminder that there is a gap in C++ codegen). |
@nicksnyder Agree. I updated the PR. I'll create another PR for the test cases |
in
rule for repeatet int32
in
rule for repeated int32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks again
Fix generating lookup for
repeated.items.int32.in
This PR fixes the
in
field validation for repeated int32 fields.The current generated code doesn't emit the lookup map e.g.
I also added a Test cases for both int32 and int64