Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python >=3.10 #111

Merged
merged 16 commits into from
Dec 12, 2023
Merged

Support Python >=3.10 #111

merged 16 commits into from
Dec 12, 2023

Conversation

Alfus
Copy link
Collaborator

@Alfus Alfus commented Dec 12, 2023 •
edited
Loading

datetime.UTC -> datetime.timezone.utc and some pytest deps

@Alfus Alfus changed the title run ci against old python versions Run ci against old python versions Dec 12, 2023
@Alfus Alfus changed the title Run ci against old python versions Support Python >=3.8 Dec 12, 2023
@Alfus Alfus marked this pull request as ready for review December 12, 2023 18:42
@Alfus Alfus requested a review from akshayjshah December 12, 2023 18:42
@Alfus
Copy link
Collaborator Author

Alfus commented Dec 12, 2023 •
edited
Loading

Hmm, something is odd with the ci setup:
image
It looks like if the system version of python is newer than the target one, it gets used instead. So I think this is only actually testing python 3.10.12+.

@Alfus Alfus changed the title Support Python >=3.8 Support Python >=3.10 Dec 12, 2023
@Alfus
Copy link
Collaborator Author

Alfus commented Dec 12, 2023

Fixed issue where the wrong version of python was being used in CI, which found more version compat issues, so limitting to just adding 3.10, and will follow up with a new PR for other versions.

@Alfus Alfus merged commit 91f4d95 into main Dec 12, 2023
6 checks passed
@Alfus Alfus deleted the alfus/compat branch December 12, 2023 19:39
@nicksnyder nicksnyder mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodaine rodaine rodaine approved these changes

@akshayjshah akshayjshah Awaiting requested review from akshayjshah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alfus @rodaine