Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit Python 3.13 support #204

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add explicit Python 3.13 support #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down
16 changes: 5 additions & 11 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,15 @@
name: Upload PyPi Release
name: Upload PyPI Release

on:
release:
types: [published]

env:
PYTHON_VERSION: '3.7.17'

jobs:
build:
name: Build package
runs-on: ubuntu-latest
environment:
name: release
strategy:
matrix:
python-version: [ "3.11" ]
steps:
- name: Checkout source
uses: actions/checkout@v4
Expand All @@ -25,10 +19,10 @@ jobs:
run: |
VERSION=${{github.head_ref}}
echo "VERSION=${VERSION##*/}" >> $GITHUB_ENV
- name: Set up Python ${{ matrix.python-version }}
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
python-version: "3.13"
- name: Install pypa/build
run: |
python -m pip install build
Expand All @@ -39,7 +33,7 @@ jobs:
path: dist/

publish:
name: Publish on PyPi
name: Publish on PyPI
runs-on: ubuntu-latest
environment:
name: release
Expand All @@ -56,7 +50,7 @@ jobs:
name: package
path: dist

- name: Publish on PyPi
- name: Publish on PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.PYPI_API_TOKEN }}
7 changes: 6 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ license = { file = "LICENSE" }
keywords = ["validate", "protobuf", "protocol buffer"]
requires-python = ">=3.8"
classifiers = [
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
Comment on lines -13 to +18
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have a preference; I typically follow what projects like structlog are doing, which lists out the individual supported versions (dropping them when they're no longer supported). Happy to back this out, though, and leave it implicit from the >=3.8.

"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
]
Expand Down
Loading