-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isIpPrefix #99
Add isIpPrefix #99
Conversation
higebu
commented
Sep 28, 2023
•
edited by rodaine
Loading
edited by rodaine
- protovalidate-go: Add isIpPrefix protovalidate-go#53
- protovalidate-cc: Add isIpPrefix protovalidate-cc#45 (via @paina)
- protovalidate-java: Add isIpPrefix protovalidate-java#39
- protovalidate-python: Add isIpPrefix protovalidate-python#78
d9ccde3
to
9f4f80c
Compare
Hi @higebu! Thanks for taking the time to so thoroughly implement this. Have you had a chance to look at the previous discussion on including support for CIDR blocks in the linked issue? |
Hi @rodaine! Thank you for taking a look. Sure. I'll check the issue. |
Hi @rodaine, @higebu. |
Looking good! Can you please add some conformance tests to ensure that they're correctly handling these new constraints?
You can either add this to the existing strings suite or create a new one specifically for this new rule. |
e9fa928
to
15f66ec
Compare
f000d24
to
93b53fd
Compare
@rodaine Thank you for the guidance of conformance tests. I added some conformance tests and will fix protovalidate-xxx. |
93b53fd
to
476b0fc
Compare
@rodaine I fixed protovalidate-python and protovalidate-java with conformance tests. BTW, how to run protovalidate-conformance with protovalidate-go and protovalidate-cc? They seems to depends on bufbuild/protovalidate@v0.4.2, so I can't not test with development version of protovalidate. |
Hey @higebu! Going to start merging these so you should be able to update the conformance tests for the libraries downstream. |
Related to: bufbuild/protovalidate#99 --------- Co-authored-by: Chris Roche <github@rodaine.com>
Related to: bufbuild/protovalidate#99 --------- Co-authored-by: Chris Roche <github@rodaine.com>
Related to: bufbuild/protovalidate#99
Related to: bufbuild/protovalidate#99 Based on @higebu's idea on the PR, I've implemented `isIpPrefix()` for C++. --------- Co-authored-by: Chris Roche <github@rodaine.com>