-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use v2 API format #111
Merged
Merged
Use v2 API format #111
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
166ce57
Use v2 format
kattrali 958766c
Use ‘manual’ in place of custom
kattrali 0f0c27a
Enforce size limit
kattrali 9f21085
Document breadcrumb types
kattrali bc6cbfe
Update example
kattrali a2c51be
Add a breadcrumb when an error occurs
kattrali 6f95a06
Add a Makefile
kattrali 44e2f85
Update payload version
kattrali 90a5568
Cleanup types
kattrali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
all: build | ||
|
||
.PHONY: build test clean | ||
|
||
build: | ||
./gradlew build | ||
|
||
clean: | ||
./gradlew clean | ||
|
||
test: | ||
./gradlew :connectedCheck |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
package com.bugsnag.android; | ||
|
||
/** | ||
* Recognized types of breadcrumbs | ||
*/ | ||
public enum BreadcrumbType { | ||
/** | ||
* An error was sent to Bugsnag (internal use only) | ||
*/ | ||
ERROR ("error"), | ||
/** | ||
* A log message | ||
*/ | ||
LOG ("log"), | ||
/** | ||
* A manual invocation of `leaveBreadcrumb` (default) | ||
*/ | ||
MANUAL ("manual"), | ||
/** | ||
* A navigation event, such as a window opening or closing | ||
*/ | ||
NAVIGATION ("navigation"), | ||
/** | ||
* A background process such as a database query | ||
*/ | ||
PROCESS ("process"), | ||
/** | ||
* A network request | ||
*/ | ||
REQUEST ("request"), | ||
/** | ||
* A change in application state, such as launch or memory warning | ||
*/ | ||
STATE ("state"), | ||
/** | ||
* A user action, such as tapping a button | ||
*/ | ||
USER ("user"); | ||
|
||
private final String type; | ||
|
||
BreadcrumbType(String type) { | ||
this.type = type; | ||
} | ||
|
||
String serialize() { return type; } | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about making this the implementation of
toString()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compiler wasn't a fan, though maybe I missed something:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you make it public? If you override toString you need to make it public otherwise it will be trying to reduce the access privileges of an inherited method which is not allowed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense and would've made a good error message. Patched in b63033e. Non-breaking change since it was package scoped before.