Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around NPEs from Intent.getExtras #2083

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Sep 30, 2024

Goal

Fix #2082 by wrapping the Intent.getExtras() in a try {} catch {}

Testing

Introduced a new unit test to cover this specific case.

@lemnik lemnik requested a review from YYChen01988 September 30, 2024 10:33
@lemnik lemnik force-pushed the PLAT-12834/ActivityBreadcrumbCollectorFix branch from ab3312f to 98e7c78 Compare September 30, 2024 10:34
@lemnik lemnik force-pushed the PLAT-12834/ActivityBreadcrumbCollectorFix branch from 98e7c78 to c88f726 Compare September 30, 2024 10:41
Copy link
Contributor

@YYChen01988 YYChen01988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1854.01 1674.72
arm64_v8a 631.04 450.82
armeabi_v7a 565.51 385.29
x86 708.85 528.62
x86_64 676.09 495.86

Generated by 🚫 Danger

@lemnik lemnik merged commit 9f2add0 into next Sep 30, 2024
54 checks passed
@lemnik lemnik deleted the PLAT-12834/ActivityBreadcrumbCollectorFix branch September 30, 2024 11:30
@lemnik lemnik mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException in ActivityBreadcrumbCollector when accessing Intent extras
3 participants