Identify the error reporting thread in native crashes #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-12699/ndk-reporting-thread
branch
from
d3362ca to
db4cdc3
Compare
Android notifier sizes
Generated by 🚫 Danger |
lemnik
force-pushed
the
PLAT-12699/ndk-reporting-thread
branch
from
db4cdc3 to
d54e6fb
Compare
kstenerud
approved these changes
Oct 7, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Identify the error reporting thread in native crashes
Design
Introduced the error reporting thread boolean marker to the
bsg_threadstructure, and attempt to match the TID with the currently running thread (within the signal handler & C++ exception handler).Testing
Additional steps added to the existing native smoke test