Improved EventPayload for Delivery #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
requested review from
kstenerud,
tomlongridge,
YYChen01988 and
hannah-smartbear
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
approved these changes
Oct 24, 2024
lemnik
force-pushed
the
PLAT-12835/improved-delivery
branch
from
997be71 to
c6c8745
Compare
…yload, DeliveryStatus, and Session to allow easier development of new `Delivery` implementations
…liverable is more natural to implement from Java
…crumbs in EventPayload.trimToSize
…Static for easier use in Java
…hods to avoid breaking binary compatibility
lemnik
force-pushed
the
PLAT-12835/improved-delivery
branch
from
4387507 to
f2a0afa
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Make it easier to build new
Deliveryimplementations without requiring the use of internal classes.Design
Updated the
EventPayloadclass to have the trimming logic and integrity-header generation.Changeset
EventPayloadandSessionboth now include atoByteArray()function that will encode them in JSON suitable for direct delivery over HTTP.EventPayloadalso includes the calculations for theBugsnag-Integrityheader, and the payload trimming logic that was previously inDefaultDeliveryA new
OkHttpDeliveryimplementation ofDeliveryhas been added to thebugsnag-plugin-android-okhttpmodule, allowing for the reuse of externally configuredOkHttpClients to be used for delivery of sessions and events.Testing
New end to end scenario