Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synthesize native crash and anr reports #2094

Merged
merged 17 commits into from
Nov 14, 2024
Merged

synthesize native crash and anr reports #2094

merged 17 commits into from
Nov 14, 2024

Conversation

YYChen01988
Copy link
Contributor

Goal

Events with anr and native crash report when they happens on the background.

Changeset

Register the event store empty callback and synthesized ANR and native crash events

Testing

Manual testing on real devices

YYChen01988 and others added 14 commits September 27, 2024 11:07
@YYChen01988
feat(ExitInfo): ExitInfo setOnEventStoreEmptyCallback
259cd2a
@YYChen01988
feat(ExitInfo): ExitInfo setOnEventStoreEmptyCallback
a2ce447
@YYChen01988
Merge branch 'integration/synthesise-ANR-and-native-crash-reports' in…
b53ed82 
…to PLAT-12589/add-onEventStoreEmptyCallback
@YYChen01988
feat(ExitInfo): Track exitinfokey with event
b1735cb
@YYChen01988
feat(ExitInfo):new event with Anr exitInfo
8c56be0
@lemnik @YYChen01988
refactor(EventStore): reworked the EventStore callback to only be cal…
918f6c7 
…led once, and only when the store is completely empty (no files in queue or in storage)
@lemnik @YYChen01988
feat(ExitInfo):new event with Anr exitInfo
9f39069
@YYChen01988
feat(ExitInfo): ExitInfo setOnEventStoreEmptyCallback
db56b85
@lemnik @YYChen01988
refactor(EventStore): reworked the EventStore callback to only be cal…
4f051d5 
…led once, and only when the store is completely empty (no files in queue or in storage)
@lemnik @YYChen01988
refactor(EventStore): reworked the EventStore callback to only be cal…
07e73de 
…led once, and only when the store is completely empty (no files in queue or in storage)
@YYChen01988
feat(ExitInfo): ExitInfo setOnEventStoreEmptyCallback
5aa1feb
@YYChen01988
feat(ExitInfo):new event with Anr exitInfo
472c42c
@YYChen01988
feat(ExitInfo):new event with Anr exitInfo
149fb34
@YYChen01988
feat(ExitInfo):register EventStoreEmptyCallback in exitinfo plugin
fc2accd
@YYChen01988 YYChen01988 requested a review from lemnik October 25, 2024 09:01
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Oct 25, 2024 •
edited
Loading

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1862.82 1675.78
arm64_v8a 639.23 450.82
armeabi_v7a 573.7 385.29
x86 717.04 528.62
x86_64 684.28 495.86

Generated by 🚫 Danger

@YYChen01988 YYChen01988 force-pushed the PLAT-12592/synthesize-native-crash-reports branch from dc51807 to 1b33d2a Compare October 25, 2024 09:40
lemnik
lemnik reviewed Oct 25, 2024
View reviewed changes
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/BugsnagExitInfoPlugin.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/BugsnagExitInfoPlugin.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/EventSynthesizer.kt Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/EventSynthesizer.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/EventSynthesizer.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/EventSynthesizer.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/InternalHooks.java Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/InternalHooks.java Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/InternalHooks.java Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/InternalHooks.java Outdated Show resolved Hide resolved
@YYChen01988 YYChen01988 force-pushed the PLAT-12592/synthesize-native-crash-reports branch from 1b33d2a to 08e68e2 Compare October 28, 2024 09:42
@YYChen01988 YYChen01988 force-pushed the PLAT-12592/synthesize-native-crash-reports branch from 08e68e2 to afac6be Compare October 29, 2024 09:31
@YYChen01988 YYChen01988 requested a review from lemnik October 29, 2024 09:32
@YYChen01988 YYChen01988 force-pushed the PLAT-12592/synthesize-native-crash-reports branch 8 times, most recently from cb823c5 to b1725c5 Compare November 5, 2024 16:05
@YYChen01988 YYChen01988 force-pushed the PLAT-12592/synthesize-native-crash-reports branch 12 times, most recently from becd9cf to 3a84a3f Compare November 11, 2024 11:34
lemnik
lemnik reviewed Nov 11, 2024
View reviewed changes
bugsnag-android-core/src/main/java/com/bugsnag/android/AppDataCollector.kt Outdated Show resolved Hide resolved
bugsnag-android-core/src/main/java/com/bugsnag/android/DeviceDataCollector.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/BugsnagExitInfoPlugin.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/BugsnagExitInfoPlugin.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/BugsnagExitInfoPlugin.kt Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/EventSynthesizer.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/EventSynthesizer.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/EventSynthesizer.kt Outdated Show resolved Hide resolved
bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/EventSynthesizer.kt Outdated Show resolved Hide resolved
...nag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/ExitInfoPluginConfiguration.kt Outdated Show resolved Hide resolved
@YYChen01988 YYChen01988 force-pushed the PLAT-12592/synthesize-native-crash-reports branch from 3a84a3f to 2a89553 Compare November 11, 2024 15:26
@YYChen01988 YYChen01988 requested a review from lemnik November 11, 2024 16:52
@YYChen01988 YYChen01988 force-pushed the PLAT-12592/synthesize-native-crash-reports branch from 2a89553 to 9c0ab31 Compare November 11, 2024 16:56
@YYChen01988 YYChen01988 force-pushed the PLAT-12592/synthesize-native-crash-reports branch 2 times, most recently from c0972ea to b389819 Compare November 12, 2024 08:57
@YYChen01988 YYChen01988 requested a review from lemnik November 12, 2024 08:58
@YYChen01988 YYChen01988 force-pushed the PLAT-12592/synthesize-native-crash-reports branch 2 times, most recently from 38d8390 to f8247cd Compare November 12, 2024 09:53
@YYChen01988 YYChen01988 force-pushed the PLAT-12592/synthesize-native-crash-reports branch from f8247cd to b64c083 Compare November 12, 2024 10:11
@YYChen01988 YYChen01988 requested a review from lemnik November 12, 2024 10:21
@YYChen01988 YYChen01988 merged commit e23af62 into integration/synthesise-ANR-and-native-crash-reports Nov 14, 2024
31 checks passed
@YYChen01988 YYChen01988 deleted the PLAT-12592/synthesize-native-crash-reports branch November 14, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemnik lemnik lemnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YYChen01988 @bugsnagbot @lemnik