Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-memory ExitInfoPluginStore #2100

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Nov 8, 2024

Goal

Simplify the use of the ExitInfoPluginStore by retaining the data in-memory instead of constantly reloading from disk.

Testing

Modified existing tests to match the new fields & behaviour

@lemnik lemnik requested a review from YYChen01988 November 8, 2024 13:16
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1854.54 1674.71
arm64_v8a 631.04 450.82
armeabi_v7a 569.61 385.29
x86 708.85 528.62
x86_64 676.09 495.86

Generated by 🚫 Danger

Copy link
Contributor

@YYChen01988 YYChen01988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemnik lemnik merged commit 1c13c98 into integration/synthesise-ANR-and-native-crash-reports Nov 14, 2024
51 checks passed
@lemnik lemnik deleted the PLAT-13007/in-mem-exitinfo-store branch November 14, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants