Do not synthesize discarded events #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YYChen01988
force-pushed
the
PLAT-13027/do-not-synthesize-discarded-events
branch
from
64ba4cb to
3818ac2
Compare
Android notifier sizes
Generated by 🚫 Danger |
YYChen01988
force-pushed
the
PLAT-13027/do-not-synthesize-discarded-events
branch
2 times, most recently
from
6aa898c to
58cb07a
Compare
YYChen01988
force-pushed
the
PLAT-13027/do-not-synthesize-discarded-events
branch
from
58cb07a to
c9d9126
Compare
…nd artifacts to aid test debugging
YYChen01988
force-pushed
the
PLAT-13027/do-not-synthesize-discarded-events
branch
2 times, most recently
from
ccdd5a5 to
a0377f2
Compare
Include the mapping.txt file in the published end2end test artifacts
YYChen01988
force-pushed
the
PLAT-13027/do-not-synthesize-discarded-events
branch
3 times, most recently
from
ffdf7b7 to
e0bec01
Compare
lemnik
force-pushed
the
PLAT-13027/do-not-synthesize-discarded-events
branch
13 times, most recently
from
f27b055 to
a1d71a4
Compare
lemnik
force-pushed
the
PLAT-13027/do-not-synthesize-discarded-events
branch
from
a1d71a4 to
22596dd
Compare
…off the unmatched ANR handling by default to avoid unexpected behaviour in upgrades
lemnik
force-pushed
the
PLAT-13027/do-not-synthesize-discarded-events
branch
from
22596dd to
cbb566d
Compare
lemnik
approved these changes
Nov 26, 2024
lemnik
changed the title
lemnik
force-pushed
the
PLAT-13027/do-not-synthesize-discarded-events
branch
from
e8a300b to
6437989
Compare
YYChen01988
merged commit 33e64d1
into
integration/synthesise-ANR-and-native-crash-reports
52 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Discard event should not be synthesize.
Changeset
Added a DiscardEventCallback before ExitInfoCallback so the discarded event would not be synthesized.
Testing
Existing tests