Remove flaky MultiThreadedStartupScenario #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be made reliable and no amount of retries will stop the flakes
Android notifier sizes
Generated by 🚫 Danger |
twometresteve
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Reduce end2end test flakes by removing the MultiThreadedStartupScenario. It unfortunately can't be made reliable, and will always be flaky.
Design
This test added a large amount of weight to the test suite without providing very much value - it was simply intended to test that a call to
Bugsnagmade whileBugsnag.startwas still in progress will wait forstartto complete rather than throw the usual "Bugsnag is not started" exception. However there isn't really a way to ensure that a secondary thread calls a method strictly afterstarthas entered its lock, but before it has completed.