Fix dex-derived BuildUUID for proguard uploads #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a generated BuildUUID is required
tomlongridge
approved these changes
Mar 22, 2024
| @@ -58,7 +58,7 @@ func MergeUploadOptionsFromAabManifest(path string, apiKey string, applicationId | |||
| log.Info("Using " + aabUploadOptions["buildUuid"] + " as build ID from dex signatures") | |||
| } | |||
| } | |||
| } else if aabUploadOptions["buildUuid"] == "none" { | |||
| } else if aabUploadOptions["buildUuid"] == "none" || noBuildUuid { | |||
There was a problem hiding this comment.
Shall we ticket and/or comment here to remove this in a future release?
lemnik
force-pushed
the
PLAT-11832/dex-build-uuid
branch
from
82a605f
to
7db09ae
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Attempt to automatically derive a buildUuid from the
classes.dexfiles formapping.txtfiles.Design
If the
buildUuidfor a proguard file is not specified as either an option, or in theAndroidManifest.xmlthen the tool will attempt to locate the appropriateclassesN.dexfiles for themapping.txtfile, and derive the BuildUUID from these.Added a new
--no-build-uuid(which is mutually exclusive with--build-uuid) to the various Android upload options. If this is specified thebuildUuidis set to""and no attempt is made to find or generate a BuildUUID.Testing
Manually tested