Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-11320] Fix an off-by-1 error when fetching arm64 register values that could potentially run off the end of the array #1635

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

kstenerud
Copy link
Contributor

Goal

Fix an off-by-1 error when fetching arm64 register values that could potentially run off the end of the array. This was only off-by-1 and only reading, so in the worst case it would fetch bogus data for the register requested. We don't actually fetch the upper registers, but best to be safe regardless.

Testing

We never fetch the upper registers, so we don't really have anything to test, other than that it still fetches the registers we are interested in.

The existing tests make sure the register fetches still work post-fix.

Copy link

github-actions bot commented Mar 1, 2024

Bugsnag.framework binary size did not change - 713,264 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%      +8  +0.1%      +8    [__DATA]
  +0.0%      +4  +0.0%      +4    [__TEXT]
  -0.0%      -4  -0.0%      -4    __TEXT,__cstring
  -0.2%      -8  -0.2%      -8    __DATA,__const
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud merged commit b1868ef into next Mar 5, 2024
33 checks passed
@kstenerud kstenerud deleted the PLAT-11320-off-by-1 branch March 5, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants