[PLAT-11320] Fix an off-by-1 error when fetching arm64 register values that could potentially run off the end of the array #1635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix an off-by-1 error when fetching arm64 register values that could potentially run off the end of the array. This was only off-by-1 and only reading, so in the worst case it would fetch bogus data for the register requested. We don't actually fetch the upper registers, but best to be safe regardless.
Testing
We never fetch the upper registers, so we don't really have anything to test, other than that it still fetches the registers we are interested in.
The existing tests make sure the register fetches still work post-fix.