Improve "redeliveryloop error" message #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
reviewed
Aug 30, 2024
packages/delivery-expo/delivery.js
Outdated
| @@ -116,7 +116,8 @@ const initRedelivery = (networkStatus, logger, send) => { | |||
| session: new UndeliveredPayloadQueue('session', onQueueError) | |||
| } | |||
|
|
|||
| const onLoopError = e => logger.error('RedeliveryLoop error', e) | |||
| const onLoopError = (e) => | |||
| logger.error('An error occurred attempting to redelivery a payload', e) | |||
There was a problem hiding this comment.
Suggested change
| logger.error('An error occurred attempting to redelivery a payload', e) | |
| logger.error('An error occurred attempting to redeliver a payload', e) |
yousif-bugsnag
approved these changes
Sep 2, 2024
AnastasiiaSvietlova
deleted the
PLAT-12468/redeliveryloop-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Improve the error message when event redelivery fails.
Design
Changeset
Changed "Redeliveryloop error" message to "An error occurred attempting to redeliver a payload".
Testing