Bump bugsnag-android to v6. Changed redactedKeys and discardClasses types to RegExp #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
reviewed
Jul 5, 2024
packages/bugsnag_flutter/android/src/main/java/com/bugsnag/flutter/BugsnagFlutter.java
Outdated
Show resolved
Hide resolved
packages/bugsnag_flutter/android/src/main/java/com/bugsnag/flutter/BugsnagFlutter.java
Outdated
Show resolved
Hide resolved
lemnik
approved these changes
Jul 8, 2024
features/fixtures/app/lib/scenarios/start_bugsnag_scenario.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Jason <lemnik@users.noreply.github.com>
robert-smartbear
deleted the
robert/plat-12382-bugsnag-android-v6-integration
branch
Merged
robert-smartbear
added a commit
that referenced
this pull request
Jul 29, 2024
* Added null checks for client in Android code * Improved the behaviour on Android when Bugsnag is started multiple times from different contexts * Bump bugsnag-android to v6. Changed redactedKeys and discardClasses types to RegExp (#249) * Bump bugsnag-android to v6. Changed redactedKeys and discardClasses types to RegExp * Regular expressions sent to native clients now carry RegExp flags * Update features/fixtures/app/lib/scenarios/start_bugsnag_scenario.dart Co-authored-by: Jason <lemnik@users.noreply.github.com> --------- Co-authored-by: Robert <robert.smartbear@gmail.com> Co-authored-by: Jason <lemnik@users.noreply.github.com> * docs(readme): amended badge URL to scope to main branch only (#241) Co-authored-by: Tom Longridge <tom.longridge@smartbear.com> * chore(build): update package gemfile (#240) Co-authored-by: Tom Longridge <tom.longridge@smartbear.com> * Rebuilt Flutter example and fixture with Flutter 3.10 (#252) * Rebuilt flutter example * Rebuilt e2e tests fixture * Small fixes for example project * Replaced examples with a single example for pub.dev release * Small fixes for the fixture * Updated mazerunner gem to v9 * Updated mazerunner to v9 on CI * Switched Android E2E tests to be run on Browserstack on CI * Added browserstack username and access key to docker-compose.yaml * adjust pipeline for browserstack * adjust pipeline for browserstack --------- Co-authored-by: Robert <robert.smartbear@gmail.com> Co-authored-by: Josh Edney <josh.edney@smartbear.com> * Added trace ID to error events (#251) * Added spanId and traceId from span context to events * Updated iOS integration and implemented Android integration for error correlation * Changes requested in code review * Made the package publishable again * Changes requested in code review --------- Co-authored-by: Robert <robert.smartbear@gmail.com> * Updated UPGRADING.MD for v4 release (#254) * Updated UPGRADING.MD for v4 release * Update UPGRADING.MD Co-authored-by: Tom Longridge <tom@bugsnag.com> --------- Co-authored-by: Robert <robert.smartbear@gmail.com> Co-authored-by: Tom Longridge <tom@bugsnag.com> * Bumped to v4.0.0 --------- Co-authored-by: Robert <robert.smartbear@gmail.com> Co-authored-by: Jason <lemnik@users.noreply.github.com> Co-authored-by: Tom Longridge <tom@bugsnag.com> Co-authored-by: Tom Longridge <tom.longridge@smartbear.com> Co-authored-by: Josh Edney <josh.edney@smartbear.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Bump bugsnag-android to the latest version.
Design
The new version of bugsnag-android accepts redactedKeys and discardClasses only as regular expressions. In order to maintain consistency across platforms, the types in bugsnag-flutter were changed to RegExp and they are compiled to regular expressions on both native platforms.
Changeset
Changed redactedKeys and discardClasses types to RegExp.
Testing
Existing E2E tests