Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate request method and url in network breadcrumbs metadata #1988

Merged
merged 6 commits into from
Jul 17, 2023

Conversation

yousif-bugsnag
Copy link
Contributor

Goal

  • (Breaking change) Rename the request metadata field to url to match the notifier spec - the value of this is now the request URL without the method prepended.
  • Add a separate method metadata field to record the request method (e.g. GET or POST)

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 44.32 kB 13.52 kB
After 44.38 kB 13.53 kB
± ⚠️ +60 bytes ⚠️ +10 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 738816f

@yousif-bugsnag yousif-bugsnag force-pushed the PLAT-10552/remove-request-content-length branch from e2a771a to cbc15c0 Compare July 14, 2023 07:42
@yousif-bugsnag yousif-bugsnag force-pushed the PLAT-9448/rename-request-to-url branch from e503aa4 to 738816f Compare July 14, 2023 07:44
Base automatically changed from PLAT-10552/remove-request-content-length to integration/v8 July 17, 2023 08:39
@yousif-bugsnag yousif-bugsnag merged commit 28d9670 into integration/v8 Jul 17, 2023
@yousif-bugsnag yousif-bugsnag deleted the PLAT-9448/rename-request-to-url branch July 17, 2023 15:13
@gingerbenw gingerbenw mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants