Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-12111] Add Access-Control-Max-Age header #2160

Merged
merged 7 commits into from
Sep 23, 2024
Merged

[PLAT-12111] Add Access-Control-Max-Age header #2160

merged 7 commits into from
Sep 23, 2024

Conversation

AnastasiiaSvietlova
Copy link
Contributor

@AnastasiiaSvietlova AnastasiiaSvietlova commented Jun 14, 2024 •
edited
Loading

Goal

Add the Access-Control-Max-Age response header to CORS POST requests sent to https://notify.bugsnag.com/. Without this header, preflight responses are only cached for 5 seconds.

Changeset

Added Access-Control-Max-Age header to delivery.sendEvent

Testing

Update existing unit test

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.24 kB 13.74 kB
After 45.31 kB 13.78 kB
± ⚠️ +79 bytes ⚠️ +37 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 80300f8

@AnastasiiaSvietlova AnastasiiaSvietlova changed the title added Access-Control-Max-Age header to delivery.sendEvent [PLAT-12111] Add Access-Control-Max-Age header Jun 14, 2024
@AnastasiiaSvietlova AnastasiiaSvietlova marked this pull request as ready for review June 14, 2024 13:34
@AnastasiiaSvietlova AnastasiiaSvietlova merged commit 6ae56c4 into next Sep 23, 2024
64 checks passed
@AnastasiiaSvietlova AnastasiiaSvietlova deleted the PLAT-12111-headers-for-CORS-preflight-responses branch September 23, 2024 10:20
@mclack mclack mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gingerbenw gingerbenw gingerbenw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnastasiiaSvietlova @gingerbenw