Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add asyncNotifyException method (for one-level deep async stacktraces) #242

Closed
wants to merge 2 commits into from
Closed

Add asyncNotifyException method (for one-level deep async stacktraces) #242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdca98b
Add asyncNotifyException method (for one-level deep async stacktraces)
jmshal Jun 3, 2017
9703fd4
Add IE support for asyncNotifyException
jmshal Jun 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/bugsnag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,18 @@
// is configurable via the `maxDepth` setting.
maxPayloadDepth = 5;

var stacktraceName;
try {
throw Error('');
} catch(err) {
stacktraceName = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comment on which browsers use which error property for the stack trace would be nice.

err.backtrace
? 'backtrace'
: err.stacktrace
? 'stacktrace'
: 'stack'
);
}

// Set default breadcrumbLimit to 20, so we don't send a giant payload.
// This can be overridden up to the breadcrumbHardLimit
Expand Down Expand Up @@ -66,6 +78,36 @@
// ### Manual error notification (public methods)
//

// #### Bugsnag.autoNotifyException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should say asyncNotifyException

//
// Creates a closure which, when called, modifies the Error object to contain the
// stacktrace of the caller. This allows for one-level deep async stacktraces from
// within Promise chains.
//
// Example:
// function badFunction() {
// fetch(...)
// .then(() => throw new Error('Something bad happened...'))
// .catch(Bugsnag.asyncNotifyException());
// }
//
// In the example above, whatever code ends up calling `badFunction` will also be
// included in the stacktrace when the `fetch` Promise chain rejects.
self.asyncNotifyException = function () {
var beforeStacktrace;
try {
throw new Error('');
} catch(err) {
beforeStacktrace = stacktraceFromException(err)
.replace('Error\n', '') // Remove Chrome's empty "Error" line
.split('\n').slice(1).join('\n');
}
return function (err) {
err[stacktraceName] += '\n' + beforeStacktrace;
return self.notifyException.apply(self, arguments);
};
};

// #### Bugsnag.notifyException
//
// Notify Bugsnag about a given `exception`, typically that you've caught
Expand Down