Work around PHP phar realpath restrictions #223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP's
realpath
function does not permit evaluating paths within "phar" files. This means that in our service provider, the$source
variable is evaluated tofalse
whenever someone tries to package up "bugsnag-laravel" in a "phar":This can be mitigated by replacing the first line of the function body with:
since it's not absolutely required to use the "real path".
This change just falls back to the relative path if we are not able to compute the real path.
Closes #222. Related: https://bugs.php.net/bug.php?id=52769.
Thanks to @praalhans for the report.