Remove duplicate app["events"] dispatch from MultiLogger
#337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gsnag MultiLogger
kattrali
approved these changes
Jan 15, 2019
jpcid
added a commit
to jpcid/bugsnag-laravel
that referenced
this pull request
Mar 17, 2019
* master: Tests: Add Laravel 5.8 Tests (bugsnag#345) Release v2.15.2: Changelog and version updates (bugsnag#342) Example: Laravel 57 example initial commit (bugsnag#339) fix: Remove duplicate `app["events"]` dispatch from MultiLogger (bugsnag#337) Fixed maze tests: Fix changing error message between laravel 5.6.12 and 5.6.21 (bugsnag#338) build: Exclude .github folder from release archive (bugsnag#334) Release v2.15.1 fix: Exclude features/ from release artifact v2.15.0 Release (bugsnag#328) ci: Run end-to-end tests (bugsnag#323)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Removes the
app['events']dispatcher from theMultiLoggersetup, as it's already present in theLaravelLogger, preventing duplicateeventsbeing fired.Fixes #306