Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documenting the bugsnag facade adding support to code-completion #373

Closed

Conversation

danieldevsquad
Copy link
Contributor

@danieldevsquad danieldevsquad commented Nov 16, 2019

Goal

Documenting the bugsnag facade will allow code-completion tools to display useful information about available methods.

This change introduces a subset of the (arguably) most commonly used features available throw the commented facade: \Bugsnag\BugsnagLaravel\Facades\Bugsnag.

Changeset

none

Tests

Not applicable

Discussion

Alternative Approaches

Inspired in the same patterns used to document facades in Laravel core packages.

Outstanding Questions

None

Linked issues

None

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@mattdyoung
Copy link

@danieldevsquad
Thanks for the PR. We'll take a look.

@mattdyoung mattdyoung added the feature request Request for a new feature label Nov 19, 2019
@bugsnagbot bugsnagbot added the scheduled Work is starting on this feature/bug label Jul 8, 2020
imjoehaines added a commit that referenced this pull request Sep 9, 2020
@imjoehaines
Copy link
Contributor

Thanks for the PR @danieldevsquad!

I'll merge this in #408 with some extra methods and changelog entry added 🙂

@imjoehaines imjoehaines closed this Sep 9, 2020
@imjoehaines imjoehaines mentioned this pull request Sep 9, 2020
@steve-nester-uk steve-nester-uk added released This feature/bug fix has been released and removed scheduled Work is starting on this feature/bug labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature released This feature/bug fix has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants