-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed determining the builder name #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for moving this to bugsnag-php? I wouldn't have thought we want to add Symfony dependencies there in order to keep in framework-neutral. Can't we keep this functionality in bugsnag-laravel?
Well, the PHP notifier still doesn't depend on symfony. It just uses it if it's available. We could actually delete the symfony code entirely if we really wanted. |
OK, not depend in the Composer sense but I would say for the |
I wouldn't say deleting this code is a breaking change. It's just the internals of the library. We were not getting the process class instance from the container, so users had no opportunity to mess with it. |
I would generally favor an approach that means we have bugsnag-php that includes plugins for all the php frameworks we want to support. This is how ruby/python work and it means we don't have dependency issues. If that is the way it could be built, I would be generally supportive of that - cc @kattrali |
We've discussed this and agreed that there's no need for the Symfony code as there's no reason the native way of executing process calls wouldn't work. So we can merge this and close bugsnag/bugsnag-php#572. |
Depends on bugsnag/bugsnag-php#572. Closes #369.