Fix possible crash in the OOM bootstrapper #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen when the DI container isn't totally setup, which is very common when running unit tests See #440
The OomBootstrapper is tested in our MazeRunner suite, so I've not replicated that here as it'd take a fair amount of setup to get running. Instead, these tests run the OomBootstrapper and will fail if it crashes
imjoehaines
commented
Apr 22, 2021
kattrali
approved these changes
Apr 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR fixes a possible crash in
OomBootstrapper, which happens when Bugsnag is not in the DI container. This would typically only be in situations where the container that's being used doesn't contain every service, i.e. when running unit testsI've added some simple tests that check specifically for this crash — the functionality of the
OomBootstrapperis already tested with MazeRunner