Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow installation on Laravel 9 projects #477

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Allow installation on Laravel 9 projects #477

merged 5 commits into from
Feb 8, 2022

Conversation

imjoehaines
Copy link
Contributor

Goal

#470 ended up with a conflict, so I've rebased it in this PR. I've also:

  • added a changelog entry
  • removed the temporary workaround to run the MR tests on Laravel 9
  • added Laravel 9 to the unit test matrix
  • bumped the bugsnag/bugsnag dependency to 3.27.0 (latest)

@imjoehaines imjoehaines requested a review from kattrali February 8, 2022 16:39
@imjoehaines imjoehaines mentioned this pull request Feb 8, 2022
Closed
kattrali
kattrali approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there anything we should be pruning from the unit test matrix?

@imjoehaines
Copy link
Contributor Author

is there anything we should be pruning from the unit test matrix?

I think it's ok — even though it's a huge matrix it finishes in ~1-2 minutes, which is faster than the license audit and Maze Runner tests

@imjoehaines imjoehaines merged commit 35a9c24 into next Feb 8, 2022
@imjoehaines imjoehaines deleted the laravel9 branch February 8, 2022 16:59
@imjoehaines imjoehaines mentioned this pull request Feb 8, 2022
Merged
@luke-belton luke-belton mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali kattrali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imjoehaines @kattrali @jdanino