Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Monolog v3 #489

Merged
merged 1 commit into from
May 20, 2022
Merged

Allow Monolog v3 #489

merged 1 commit into from
May 20, 2022

Conversation

imjoehaines
Copy link
Contributor

Goal

Laravel v10 will require Monolog v3 (laravel/framework#42311), so we'll also need to allow it so that we can be compatible when it eventually releases. This is required to allow testing against pre-release versions and to allow our nightly "unstable" builds to run again

We only use Monolog in one place and the APIs we use haven't changed in v3, so no other changes are required:

$this->app['log']->extend('bugsnag', function (Container $app, array $config) {
$handler = new PsrHandler($app['bugsnag.logger']);
return new Logger('bugsnag', [$handler]);
});

@imjoehaines imjoehaines requested a review from kattrali May 20, 2022 15:00
@imjoehaines imjoehaines changed the base branch from next to master May 20, 2022 15:01
Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easiest major version support 😎

@imjoehaines imjoehaines merged commit 537e26f into master May 20, 2022
@GrahamCampbell
Copy link
Contributor

This PR doesn't do anything because the laravel 9 requirements prevent the tests ever installing monolog 3.

@GrahamCampbell
Copy link
Contributor

Check the build logs on github actions. :)

@imjoehaines imjoehaines mentioned this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants