Add tests for queued jobs in Laravel 9 #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to run the queue worker and HTTP server in the same docker container, I've enabled the 'init' option. This runs an init process as PID 1, which then spawns the queue worker & HTTP server See https://docs.docker.com/config/containers/multi-service_container/ and https://docs.docker.com/compose/compose-file/compose-file-v3/#init We _could_ do this with multiple containers, but that adds a lot more complexity for no real gain since we'd need 2 additional containers to accomplish the same thing (a database and a queue worker) This reduces the number of moving parts, making less likely to flake
This shows the 'job.attempts' gets incremented for each attempt
Cawllec
reviewed
Nov 29, 2022
Cawllec
approved these changes
Nov 29, 2022
This was referenced Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds tests for exception handling in queued jobs in the Laravel 9 fixture
I've used docker's init feature to allow running multiple processes in the same docker container. This simplifies the fixture setup as otherwise we'd need 2 more containers — a database and queue worker
When using the init flag docker will spawn an init process as PID 1, which can then spawn more processes. This lets us run the HTTP server and queue worker in the same database. I've configured the fixture to use an sqlite database as well, to avoid having to run a separate database server
The queue worker is started by a new "I start the laravel queue worker" step, which uses
docker compose execto run the actual command in the same container that's running the HTTP server. I've monkey patched this into theMaze::Dockerclass, but am intending on contributing it back at some point — the change is done but needs some tests in MR itselfThe same test will be implemented in other fixtures in separate PRs to avoid this being unreviewable