-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.25.1 #515
Merged
Merged
Release v2.25.1 #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a CLI command is run, NunoMaduro\Collision will end up in the backtrace where we expected to find a built-in Laravel or Lumen class This meant the UnhandledState middleware was not correctly marking these events as 'unhandled' The BacktraceProcessor now supports 'NunoMaduro\Collision' as a vendor namespace and so can mark these events as unhandled correctly
Fix events from CLI commands always being marked handled
Run queue tests with Laravel 6
Run queue tests with Laravel 5.8
Run queue tests with Laravel 5.6
Run queue tests with Laravel 5.1
This turns out not to be necessary
This isn't possible in Laravel 5.1, so we do it in the queue worker command with the '--tries' flag instead
This was useful when it ran multiple commands (the webserver & queue worker) but is not necessary now that it only runs the webserver
This doesn't create the database in other Laravel versions and it makes sense for this to be consistent with the other fixtures
The database file is created in the dockerfiles so cannot be changed The Laravel 5.1 fixture is already not configurable
Cleanup fixtures
Add tests that run the queue worker once
Add assertions on breadcrumbs to queue tests
Currently we never flush the queue of events when using Laravel Vapor because it does not call our shutdown function or the 'looping' event We need to: 1. flush events in 'after' and 'exceptionOccurred' in order to send any events created during the execution of a job 2. disable batch sending in 'after' and 'exceptionOccurred' so that any events created when a job finishes get sent synchronously. Otherwise we'd fail to send these events if the queue worker doesn't run another job 3. Re-enable batch sending in 'before' if we previously disabled it. This allows users to get the performance benefits of batch sending while their job is running (though it's much less relevant in a queue process)
This stops breadcrumbs leaking between jobs
Ensure events are sent from queues when using Laravel Vapor
kattrali
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements
#511
Bug fixes
Fix events from CLI commands always being handled when using the
NunoMaduro\Collision
package#503
Fix breadcrumbs leaking between queued jobs when using Laravel Vapor
#511