Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.25.1 #515

Merged
merged 38 commits into from
Jan 17, 2023
Merged

Release v2.25.1 #515

merged 38 commits into from
Jan 17, 2023

Conversation

imjoehaines
Copy link
Contributor

Enhancements

  • Ensure events are sent from queues when using Laravel Vapor
    #511

Bug fixes

  • Fix events from CLI commands always being handled when using the NunoMaduro\Collision package
    #503

  • Fix breadcrumbs leaking between queued jobs when using Laravel Vapor
    #511

When a CLI command is run, NunoMaduro\Collision will end up in the
backtrace where we expected to find a built-in Laravel or Lumen class

This meant the UnhandledState middleware was not correctly marking these
events as 'unhandled'

The BacktraceProcessor now supports 'NunoMaduro\Collision' as a vendor
namespace and so can mark these events as unhandled correctly
Fix events from CLI commands always being marked handled
This turns out not to be necessary
This isn't possible in Laravel 5.1, so we do it in the queue worker
command with the '--tries' flag instead
This was useful when it ran multiple commands (the webserver & queue
worker) but is not necessary now that it only runs the webserver
This doesn't create the database in other Laravel versions and it makes
sense for this to be consistent with the other fixtures
The database file is created in the dockerfiles so cannot be changed

The Laravel 5.1 fixture is already not configurable
Add tests that run the queue worker once
Add assertions on breadcrumbs to queue tests
Currently we never flush the queue of events when using Laravel Vapor
because it does not call our shutdown function or the 'looping' event

We need to:

1. flush events in 'after' and 'exceptionOccurred' in order to send any
   events created during the execution of a job
2. disable batch sending in 'after' and 'exceptionOccurred' so that any
   events created when a job finishes get sent synchronously. Otherwise
   we'd fail to send these events if the queue worker doesn't run
   another job
3. Re-enable batch sending in 'before' if we previously disabled it.
   This allows users to get the performance benefits of batch sending
   while their job is running (though it's much less relevant in a
   queue process)
This stops breadcrumbs leaking between jobs
Ensure events are sent from queues when using Laravel Vapor
@imjoehaines imjoehaines requested a review from kattrali January 16, 2023 10:32
@imjoehaines imjoehaines merged commit f8aac58 into master Jan 17, 2023
@imjoehaines imjoehaines deleted the release/v2.25.1 branch January 17, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants