Let Laravel decide whether to report or not #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Laravel 5.2,
Illuminate\Foundation\Exceptions\Handler::shouldntReport()
was modified to never reportIlluminate\Http\Exception\HttpResponseException
exceptions. This updated logic was never captured in theBugsnagExceptionHandler
, so in a Laravel 5.2 application, allHttpResponseException
s are reported by default when they shouldn't be.It makes sense to just use
$this->shouldReport($e)
to determine if the exception should be reported - that way no logic is duplicated, and ifshouldReport()
is modified again in the future, there will be no need to update this package.The
shouldReport()
method has been present since 5.0 so this change is compatible with 5.0-5.2.