Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure that the "type" parameter has a sensible default #421

Merged
merged 5 commits into from
Nov 13, 2017

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Nov 1, 2017

Ensures that the "type" parameter in the "severityReason" has a sensible default.

@GrahamCampbell
Copy link
Contributor

What is wrong with the way it is right now?

@Cawllec
Copy link
Contributor Author

Cawllec commented Nov 2, 2017

Users creating and notifying reports manually can set the severity reason to something invalid, in some cases without including a type parameter. This was requested to avoid not having any type in the future.

@kattrali kattrali merged commit 7a95cf4 into master Nov 13, 2017
@kattrali kattrali deleted the cawllec/severity-type-default branch November 13, 2017 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants