Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'addMetaData' method to reports #430

Merged
merged 7 commits into from
Dec 11, 2017
Merged

Add 'addMetaData' method to reports #430

merged 7 commits into from
Dec 11, 2017

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Dec 5, 2017

Adds an 'addMetaData' method to the Report object to allow easy creation/deletion/updating of report metadata.

  • Accepts an array
  • Adds new properties into the metadata array if they don't already exist
  • Merges conflicting properties recursively if necessary, favouring new metadata
  • Deletes properties with values that are null

Implements #268

@Cawllec Cawllec added the feature request Request for a new feature label Dec 5, 2017
@kattrali kattrali merged commit d1b1fb3 into master Dec 11, 2017
@kattrali kattrali deleted the cawllec/add-meta-data branch December 11, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature request Request for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cawllec @kattrali