Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setProjectRootRegex method #514

Merged
merged 9 commits into from
Jan 29, 2019

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Jan 23, 2019

Goal

Adds setProjectRootRegex to the Configuration class, allowing the projectRoot regex to be set directly.

Based on #501 by @jpcid, this adds additional tests and a dedicated method in the Client class to allow calling the added setProjectRootRegex method in the Configuration.

Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from needing to handling strip path. It makes sense that the project root regex would be stripped from paths automatically, as that's how it works under the hood anyway for setProjectRoot().

src/Configuration.php Show resolved Hide resolved
src/Configuration.php Outdated Show resolved Hide resolved
@jpcid
Copy link

jpcid commented Mar 18, 2019

You guys are awesome! I was very busy last month and I did not have time to apply your feedback to the original PR

Thank you @kattrali and @Cawllec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants