Support suppressed errors using "@" to ignore exceptions #537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Exception reporting can be suppressed for an expression by prefixing it with the error control operator "@". This is correctly ignored by the notifier if the error reporting level is not configured in the library but it is not suppressed if an error reporting level has been configured.
The PHP documentation states that custom error handlers:
Therefore this change ensures that suppressed errors are always ignored and not reported to Bugsnag.
Changeset
Changed
shouldIgnoreErrorCode
to return true in all cases if the error is suppressed (i.e.error_reporting()
returns0
).Tests
Added extra tests for this functionality - including mocking the
error_reporting
global function.Linked issues
Fixes bugsnag/bugsnag-wordpress#35.
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: