Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make session delivery obey the release stage rules used by notify #542

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

tomlongridge
Copy link
Contributor

@tomlongridge tomlongridge commented Sep 6, 2019

Goal

Unlike other notifiers, bugsnag-php does not check Configuration::shouldNotify when delivering session payloads.

Changeset

Changed

  • SessionTracker - added extra check on deliverSessions

Tests

  • Added new 'SessionTrackerTest` class as this doesn't seem to be covered at this level

Linked issues

Fixes bugsnag/bugsnag-laravel#362

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@tomlongridge tomlongridge marked this pull request as ready for review September 6, 2019 11:17
@tomlongridge tomlongridge requested a review from Cawllec September 6, 2019 14:05
@tomlongridge tomlongridge merged commit b356a21 into master Oct 25, 2019
@tomlongridge tomlongridge deleted the tom/send-sessions-should-obey-release-stages branch October 25, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A way to NOOP http requests in non-production env
2 participants